lkml.org 
[lkml]   [2006]   [Mar]   [5]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 2.6.16-rc5-mm2] sched_cleanup-V17 - task throttling patch 1 of 2
FromMike Galbraith <>
DateSun, 05 Mar 2006 07:54:53 +0100
On Sun, 2006-03-05 at 08:37 +1100, Peter Williams wrote:
> Mike Galbraith wrote:> > On Sat, 2006-03-04 at 10:58 +1100, Peter Williams wrote:
> > > > > >>If you're going to manage the time slice in nanoseconds why not do it 
> >>properly?  I presume you've held back a bit in case you break something?
> >>> > > > > > Do you mean the < NS_TICK thing?  The spare change doesn't go away.> > Not exactly.  I mean "Why calculate time slice in jiffies and convert to 
> nanoseconds?  Why not just do the calculation in nanoseconds?"

Turns out that my first instinct was right, and there is a good reason
not to.  It doesn't improve readability nor do anything functional, it
only adds clutter.  I much prefer the look of plain old ticks, and
having nanoseconds only intrude where they're required.  I did change
NS_TICK to the less obfuscated (1000000000 / HZ), with task_timeslice()
returning a more readable ticks * NS_TICK conversion.
	-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-05 08:47    [from the cache]
©2003-2008