Messages in this thread | | | Date | Sat, 4 Mar 2006 15:18:42 -0800 | From | Greg KH <> | Subject | Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT |
| |
On Fri, Mar 03, 2006 at 01:42:36PM -0800, Chris Leech wrote: > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index 13abfa2..b792048 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -262,6 +262,9 @@ > #include <net/tcp.h> > #include <net/xfrm.h> > #include <net/ip.h> > +#ifdef CONFIG_NET_DMA > +#include <net/netdma.h> > +#endif
#ifdef is not needed here (try not to put #ifdef in .c files.) I think a few of your other usages of #ifdef in this file can also be removed with judicious use of inline functions in a .h file.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |