Messages in this thread | | | Date | Thu, 30 Mar 2006 23:30:59 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Introduce sys_splice() system call |
| |
Jens Axboe <axboe@suse.de> wrote: > > > > + ret = write_one_page(page, 0); > > > > Still want to know why this is here?? > > > > > +out: > > > + if (ret < 0) > > > + unlock_page(page); > > > > If write_one_page()'s call to ->writepage() failed, this will cause a > > double unlock. > > Can probably be improved - can I drop write_one_page() and just unlock > the page and regular cleaning will flush it out? >
Of course - commit_write() will mark the page dirty and it'll get flushed back in the normal manner. We don't need that set_page_dirty() in there either.
But we do need some O_SYNC/S_ISSYNC handling... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |