Messages in this thread | | | From | Con Kolivas <> | Subject | Re: [PATCH] mm: swsusp shrink_all_memory tweaks | Date | Fri, 31 Mar 2006 06:38:23 +1000 |
| |
On Friday 31 March 2006 03:12, Rafael J. Wysocki wrote: > OK, I have the following observations:
Thanks. > > 1) The patch generally causes more memory to be freed during suspend than > the unpatched code (good).
Yes I know you meant less, that's good.
> 2) However, if more than 50% of RAM is used by application data, it causes > the swap prefetch to trigger during resume (that's an impression; anyway > the system swaps in a lot at that time), which takes some time (generally > it makes resume 5-10s longer on my box).
Is that with this "swsusp shrink_all_memory tweaks" patch alone? It doesn't touch swap prefetch.
> 3) The problem with returning zero prematurely has not been entirely > eliminated. It's happened for me only once, though.
Probably hard to say, but is the system in any better state after resume has completed? That was one of the aims. Also a major part of this patch is a cleanup of the hot balance_pgdat function as well, which suspend no longer touches with this patch.
Cheers, Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |