Messages in this thread |  | | | Date | Thu, 30 Mar 2006 14:22:19 +1100 | | From | Nick Piggin <> | | Subject | Re: [PATCH] nommu page refcount bug fixing |
Luke Yang wrote:
>Hi all, > > The previous "nommu use compound pages" patch has a problem: when >the pages allocated is not compound page (eg: slab allocator), the >refcount value of every page still need to be set, otherwise the >get/put_page() would free a single page improperly, such as in >access_process_vm(). > >
Yep, sorry this slipped into the kernel. It's my fault for not giving Andrew a fix for it.
As you might know, page refcounting in nommu was already broken, so I'm working on a proper solution to fix it.
In the meantime though, this is a step backwards and reintroduces NOMMU special-casing in page refcounting. As a temporary fix, what I think should happen is simply for all slab allocations to ask for __GFP_COMP pages.
Could you check that fixes your problem?
Thanks, Nick
--
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |