lkml.org 
[lkml]   [2006]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] splice support #2
Jens Axboe <axboe@suse.de> wrote:
>
> > > +static void *page_cache_pipe_buf_map(struct file *file,
> > > + struct pipe_inode_info *info,
> > > + struct pipe_buffer *buf)
> > > +{
> > > + struct page *page = buf->page;
> > > +
> > > + lock_page(page);
> > > +
> > > + if (!PageUptodate(page)) {
> >
> > || page->mapping == NULL
>
> Fixed

Actually that wasn't right. If the page was truncated then we shouldn't
return -EIO to userspace. We should return zero, as this is the first
page.

Which means either returning an ERR_PTR here for -EIO or re-checking i_size
in the caller. Maybe the latter?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-30 13:19    [W:0.943 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site