lkml.org 
[lkml]   [2006]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX
On Fri, Mar 03, 2006 at 07:53:28AM +0100, Arjan van de Ven wrote:
> On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote:
...
>
> > >>+#define IFNULL(a) \
> > >>+ if (unlikely(!(a)))
> > >
> > > please please get rid of this!
> > > (same goes for the variants of this just below this)
> >
> > Ok, these were mainly debugging aids. We'll just drop them and let the
> > oops mechanism catch the (hopefully non-existent) remaining cases of
> > pointers being unexpectedly NULL.
>
> you can also use WARN_ON() and BUG_ON() for that, you then get a more
> readable oops message (with filename and line information)
>

Yes, but please only WARN_ON(), BUG_ON should be only used, if here is no
way to recover or if continue will cause major data corruption, I do not
think thats the case anywhere in the driver.

--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-03 10:47    [W:0.099 / U:1.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site