Messages in this thread |  | | | Date | Fri, 3 Mar 2006 16:03:58 -0800 | | From | Andrew Morton <> | | Subject | Re: [PATCH 1/15] EDAC: switch to kthread_ API |
| |
Dave Peterson <dsp@llnl.gov> wrote: > > On Friday 03 March 2006 07:57, Doug Thompson wrote: > > Currently the timer event code performs two operations: > > > > 1) ECC polling and > > 2) PCI parity polling. > > > > I want to split those from each other, so each can have a seperate cycle > > rate (also adding a sysfs cycle control for the PCI parity timing in > > addition to the existing ECC cycle control). > > Yes, this sounds like a good idea. Using schedule_delayed_work() to > independently implement each polling cycle, we should be able to get > rid of the EDAC kernel thread.
That would suit. One needs to be quite careful about killing everything off in the close->rmmod side of things, especially if the delayed work handler re-arms itself. We have a pending (and possibly executing) timer handler to worry about, then a pending (and possibly executing) keventd handler to worry about.
We've got this cancel_rearming_delayed_work() thing - I was never terribly happy about it, but I think it works.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |