Messages in this thread | | | Date | Fri, 3 Mar 2006 12:48:02 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 10/15] EDAC: edac_mc_add_mc() fix [1/2] |
| |
Dave Peterson <dsp@llnl.gov> wrote: > > On Thursday 02 March 2006 18:31, Andrew Morton wrote: > > Dave Peterson <dsp@llnl.gov> wrote: > > > This is part 1 of a 2-part patch set. The code changes are split into > > > two parts to make the patches more readable. > > > > Will the code compile and run with just #1-of-2 applied? > > It should compile. Assuming that it does, would it still have been > preferable to just combine the two into a single patch?
It's better as you had it. First patch moves the functions without changing them, the second patch changes them. The mantra is "one concept per patch".
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |