lkml.org 
[lkml]   [2006]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [rfc] fix Kconfig, hotplug_cpu is needed for swsusp
On Thu, Mar 30, 2006 at 09:36:16AM +1000, Nigel Cunningham wrote:
> Hi.
>
>
> So if you have a single core x86, you want X86_PC, and if you have HT or SMP,
> you want GENERICARCH? If so, could this be done via selects or depends or at
> least defaults in Kconfig?

Yes, i think only SUSPEND_SMP is affect by this. I thought Rafael cced Pavel during
that exchange, maybe i missed.

>
> Regards,
>
> Nigel

How about this patch.

Make SUSPEND_SMP depend on X86_GENERICARCH, since hotplug cpu requires !X86_PC
due to some race in IPI handling. See more discussion here

http://marc.theaimsgroup.com/?l=linux-kernel&m=114303306032338&w=2

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
--------------------------------------------------------------

Index: linux-2.6.16-git16/kernel/power/Kconfig
===================================================================
--- linux-2.6.16-git16.orig/kernel/power/Kconfig
+++ linux-2.6.16-git16/kernel/power/Kconfig
@@ -96,5 +96,5 @@ config SWSUSP_ENCRYPT

config SUSPEND_SMP
bool
- depends on HOTPLUG_CPU && X86 && PM
+ depends on HOTPLUG_CPU && X86 && PM && X86_GENERICARCH
default y

--
Cheers,
Ashok Raj
- Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-30 01:50    [W:0.100 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site