lkml.org 
[lkml]   [2006]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 8/9] generic netlink utility functions
    On Mon, Mar 13, 2006 at 07:55:05PM -0500, Shailabh Nagar wrote:
    > genetlink-utils.patch
    >
    > Two utilities for simplifying usage of NETLINK_GENERIC
    > interface.
    >
    > Signed-off-by: Balbir Singh <balbir@in.ibm.com>
    > Signed-off-by: Shailabh Nagar <nagar@watson.ibm.com>
    >
    > include/net/genetlink.h | 20 ++++++++++++++++++++
    > 1 files changed, 20 insertions(+)
    >
    > Index: linux-2.6.16-rc5/include/net/genetlink.h
    > ===================================================================
    > --- linux-2.6.16-rc5.orig/include/net/genetlink.h 2006-03-11 07:41:32.000000000 -0500
    > +++ linux-2.6.16-rc5/include/net/genetlink.h 2006-03-11 07:41:41.000000000 -0500
    > @@ -150,4 +150,24 @@ static inline int genlmsg_unicast(struct
    > return nlmsg_unicast(genl_sock, skb, pid);
    > }
    >
    > +/**
    > + * gennlmsg_data - head of message payload
    > + * @gnlh: genetlink messsage header
    > + */
    > +static inline void *genlmsg_data(const struct genlmsghdr *gnlh)
    > +{
    > + return ((unsigned char *) gnlh + GENL_HDRLEN);
    > +}
    > +
    > +/**
    > + * genlmsg_len - length of message payload
    > + * @gnlh: genetlink message header
    > + */
    > +static inline int genlmsg_len(const struct genlmsghdr *gnlh)
    > +{
    > + struct nlmsghdr *nlh = (struct nlmsghdr *)((unsigned char *)gnlh -
    > + NLMSG_HDRLEN);
    > + return (nlh->nlmsg_len - GENL_HDRLEN - NLMSG_HDRLEN);
    > +}
    > +
    > #endif /* __NET_GENERIC_NETLINK_H */
    >
    >

    Jamal,

    Does the implementation of these utilities look ok? We use genlmsg_data()
    in the delay accounting code but not genlmsg_len(), hence it might not
    be very well tested (just reviewed).

    Thanks,
    Balbir
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-26 18:49    [W:0.037 / U:1.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site