Messages in this thread |  | | | Date | Sun, 26 Mar 2006 10:40:42 -0500 | | From | Dave Jones <> | | Subject | Re: smp_locks reference_discarded errors |
| |
On Sat, Mar 25, 2006 at 11:50:35PM -0800, Andrew Morton wrote: > Dave Jones <davej@redhat.com> wrote: > > > > since the addition of smp alternatives, the following is occuring.. > > > > Error: ./drivers/md/md.o .smp_locks refers to 0000008c R_386_32 .exit.text > > Error: ./drivers/usb/storage/libusual.o .smp_locks refers to 00000008 R_386_32 .exit.text > > Error: ./net/802/psnap.o .smp_locks refers to 00000000 R_386_32 .exit.text > > Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 00000008 R_386_32 .exit.text > > Error: ./drivers/pci/hotplug/ibmphp_hpc.o .smp_locks refers to 0000000c R_386_32 .exit.text > > > > example .config at http://people.redhat.com/davej/kernel-2.6.16-i686-smp.config > > > > I guess an atomic operation in __exit code will cause that. down() and > atomic_dec_and_test() in two cases. > > I suspect most of these callsites are just wrongly coded - it's pretty > unusual for __exit code to really need to lock anything - what is there to > be racing against? > > This is emitted by reference_discarded.pl?
came out of a 'make buildcheck' a day or two ago (the following day, Sam nuked reference_discarded.pl in favour of it being done magically somewhere else (I've not looked into how its done now).
Dave
-- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |