lkml.org 
[lkml]   [2006]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm patch] BLK_DEV_IO_TRACE Kconfig fixes
On Sun, Mar 26 2006, Adrian Bunk wrote:
> On Sun, Mar 26, 2006 at 02:27:44PM +0200, Jens Axboe wrote:
> > On Sun, Mar 26 2006, Adrian Bunk wrote:
> > > On Thu, Mar 23, 2006 at 01:40:46AM -0800, Andrew Morton wrote:
> > > >...
> > > > Changes since 2.6.16-rc6-mm2:
> > > >...
> > > > git-blktrace.patch
> > > >...
> > > > git trees.
> > > >...
> > >
> > > BLK_DEV_IO_TRACE breaks the rule "If you select something, you must
> > > endure that the dependencies of what you are select'ing are fulfilled."
> > > resulting in the following compile error with CONFIG_SYSFS=n:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > LD .tmp_vmlinux1
> > > fs/built-in.o: In function `debugfs_init':inode.c:(.init.text+0x3d35):
> > > undefined reference to `kernel_subsys'
> > > make: *** [.tmp_vmlinux1] Error 1
> > >
> > > <-- snip -->
> > >
> > > This patch fixes this bug.
> > >
> > > Additionally, it moves the BLK_DEV_IO_TRACE option that now depends on
> > > DEBUG_KERNEL into the menu with the other DEBUG_KERNEL options.
> >
> > Thanks for the sysfs fix, however don't move the kconfig entry, this
> > isn't a debug option.
>
> It select's an option depending on DEBUG_KERNEL, and therefore also has
> to depend on DEBUG_KERNEL.

IMHO that should be removed, debugfs should be generally available. At
least with blktrace, it's not necessarily a debug feature.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-26 14:40    [W:0.074 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site