![]() | |||||||||||||
Messages in this thread |
On 3/22/06, Per Liden <per.liden@ericsson.com> wrote: > On Sun, 19 Mar 2006, Jesper Juhl wrote: > > > Small cleanup patch for net/tipc/name_distr.c::tipc_named_node_up() > > Not sure if you followed the discussion on the tipc mailinglist, so here's > a short summary. > I don't read the tipc mailing list, no. > > Patch does the following: > > > > - Change a few pointer assignments from 0 to NULL (makes sparse happy). > > Ok. > > > - Move a few variable assignment outside the tipc_nametbl_lock lock. > > Ok. > Do you want a new patch with just these bits in it or will you take care of it yourself? > > - Make sure to free the allocated buffer before returning so we don't leak. > > The additional kfree_skb() looks incorrect. If a buffer if allocated it > will later be released by tipc_link_send(). > I see. Then that bit is indeed incorrect. -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-03-26 13:38 [from the cache] ©2003-2008 | |||||||||||||