Messages in this thread |  | | | Date | Sun, 26 Mar 2006 19:06:22 -0800 | | From | Joel Becker <> | | Subject | Re: [2.6 patch] CONFIGFS_FS must depend on SYSFS |
| |
On Sun, Mar 26, 2006 at 02:25:52PM +0200, Adrian Bunk wrote: > This patch fixes the following compile error with CONFIG_SYSFS=n: > > <-- snip --> > > ... > LD .tmp_vmlinux1 > fs/built-in.o: In function `configfs_init':mount.c:(.init.text+0x3d5d): undefined reference to `kernel_subsys' > make: *** [.tmp_vmlinux1] Error 1
Hmm. We only rely on SYSFS because of the policy decree of default mounting at /sys/kernel/config (just like GregKH was asked to put debugfs at /sys/kernel/debug). While we create the mount point, we don't rely on it. You can mount configfs anywhere you like. So, what do you think of making that part of the code check for CONFIG_SYSFS? Then the module can be built without SYSFS instead of depending on it. I'm open to either idea. Certainly, we don't leave the compile error.
Joel
--
Life's Little Instruction Book #313
"Never underestimate the power of love."
Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |