lkml.org 
[lkml]   [2006]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 1/2] Create initial kernel ABI header infrastructure
    On Sun, Mar 26, 2006 at 06:54:16AM -0500, Kyle Moffett wrote:
    > Create initial kernel ABI header infrastructure
    >
    >
    > diff --git a/Makefile b/Makefile
    > index af6210d..8e9045a 100644
    > --- a/Makefile
    > +++ b/Makefile
    > @@ -787,13 +787,15 @@ ifneq ($(KBUILD_SRC),)
    > /bin/false; \
    > fi;
    > $(Q)if [ ! -d include2 ]; then mkdir -p include2; fi;
    > + $(Q)if [ ! -d include2/kabi ]; then mkdir -p include2/kabi; fi;
    > $(Q)ln -fsn $(srctree)/include/asm-$(ARCH) include2/asm
    > + $(Q)ln -fsn $(srctree)/include/kabi/arch-$(ARCH) include2/kabi/arch


    No - we do not want another symlink.
    Create something like:
    include/i386/kabi-asm/ <= i386 specific files
    include/kabi/ <= general files

    Then we can do:
    LINUXINCLUDE += -Iinclude/kabi-$(ARCH)
    And the following would work like expected:
    #include <kabi/foo.h>
    #include <kabi-asm/foo.h>


    But this leaves all existing users in the dark cold.
    So a more involved approach could be to tkae the opposite approach.
    To dedicate an area for kernel only header files and make sure this
    directory is searched _before_ include/

    We could do something like
    kinclude/linux/ <= generic kernel include headers
    kinclude/$(arch)/asm/ <= arch specific include headers

    Then adding to the top-level Makefile:
    LINUXINCLUDE := -Ikinclude -Ikinclude/$(ARCH)
    LINUXINCLUDE += ...

    would actually cut it.
    Then we would not hurt existing users since they continue to use
    include/linux/* + include/asm/*
    And we could migrate one by one to the kernel clean part.

    In other words - a solution that keeps backwards compatibility.
    A solution that distingush hard between what is the ABI and
    what is kernel stuff.
    And a namespace that is not in use today.

    And we have so many users of include/linux today. They do not need
    a _kabi_ prefix so let it go.

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-26 22:09    [W:0.041 / U:61.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site