lkml.org 
[lkml]   [2006]   [Mar]   [25]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 25 Mar 2006 03:47:44 -0800
FromAndrew Morton <>
SubjectRe: SMP busted on non-cpu-hotplug systems
"David S. Miller" <davem@davemloft.net> wrote:
>
> 
> I just noticed this on sparc64, as I lost 31 cpus on my
> Niagara box due to it :)
> 
> boot_cpu_init() sets the boot processor ID in cpu_present_map.
> 
> But fixup_cpu_present_map() will only populate the cpu_present_map if
> it is empty, which it won't be because of what boot_cpu_init() just
> did.

oops.  I guess most architectures set cpu_present_map while bringing up the
APs.

I think it'd be cleanest to require that the arch do that -
fixup_cpu_present_map() looks like a bit of a hack.

I guess if we want to perpetuate fixup_cpu_present_map() then we should
teach it to ignore the boot cpu.   (cpus_weight(&cpu_present_map) == 1)
would do that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-25 12:53    [from the cache]
©2003-2008