[lkml]   [2006]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2.6.16-mm1 1/2] sched_domain: handle kmalloc failure
    On Sat, Mar 25, 2006 at 06:06:05PM -0800, Andrew Morton wrote:
    > This is rather ugly, sorry.

    That was about my reaction too when I was going thr'

    > So if the kmalloc failed we'll try to limp along without load balancing?

    Not exactly. We will still load balance at lower domains (between
    threads of a CPU & between CPUs of a node) that dont require any memory

    > I think it would be better to free any thus-far allocated memory and to
    > fail the whole thing.

    This would result in absolutely no load balancing (even for domain
    levels which didnt need any memory allocation - like at threads-of-a-cpu
    level). Is that acceptable?

    > Returning void from build_sched_domains was wrong.

    If we decide to return an error, then it has to be percolated all the
    way down (for ex: update_cpu_domains should now have to return an error
    too if partition_sched_domains returns an error)?

    > build_sched_domains() should be static and __cpuinit, btw.

    Ok ..Will take care of that in the next version of the patch.

    And thanks for the response to the patch!

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-03-26 04:43    [W:0.020 / U:0.760 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site