lkml.org 
[lkml]   [2006]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
    On Fri, Mar 24, 2006 at 09:11:58AM -0500, jamal wrote:
    > On Fri, 2006-24-03 at 07:02 +0530, Balbir Singh wrote:
    > > On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote:
    >
    > > 3. nlmsg_new() now allocates for 2*u32 + sizeof(taskstats)
    >
    > Not the right size; the u32 covers the V part of TLV. The T = 16 bits
    > and L = 16 bits. And if you nest TLVs, then it gets more interesting.
    >
    > Look at using proper macros instead of hard coding like you did.
    > grep for something like RTA_SPACE and perhaps send a patch to make it
    > generic for netlink.h
    >
    > cheers,
    > jamal
    >

    My bad, but I was wondering why my test case did not segfault until
    I saw the implementation of nlmsg_new :-)

    I will fix this and use nla_total_size() to calculate the correct sizes
    including padding and TLV.

    Thanks again,
    Balbir


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-24 16:02    [W:0.035 / U:92.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site