Messages in this thread Patch in this message | | | Subject | Re: [Patch] Pointer dereference in net/irda/ircomm/ircomm_tty.c | From | Eric Sesterhenn <> | Date | Thu, 23 Mar 2006 20:01:39 +0100 |
| |
hi,
On Thu, 2006-03-23 at 02:22 +0300, Alexey Dobriyan wrote: > On Wed, Mar 22, 2006 at 11:46:05PM +0100, Eric Sesterhenn wrote: > > this fixes coverity bugs #855 and #854. In both cases tty > > is dereferenced before getting checked for NULL. > > Before Al will flame you,
I know you prefer doing it yourself :)
> IMO, what should be done is removing asserts checking for "self", > because ->driver_data is filled in ircomm_tty_open() with valid pointer.
Updated patch below.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.16-git6/net/irda/ircomm/ircomm_tty.c.orig 2006-03-23 19:58:50.000000000 +0100 +++ linux-2.6.16-git6/net/irda/ircomm/ircomm_tty.c 2006-03-23 19:59:31.000000000 +0100 @@ -501,7 +501,6 @@ static void ircomm_tty_close(struct tty_ if (!tty) return; - IRDA_ASSERT(self != NULL, return;); IRDA_ASSERT(self->magic == IRCOMM_TTY_MAGIC, return;); spin_lock_irqsave(&self->spinlock, flags); @@ -1011,7 +1010,6 @@ static void ircomm_tty_hangup(struct tty IRDA_DEBUG(0, "%s()\n", __FUNCTION__ ); - IRDA_ASSERT(self != NULL, return;); IRDA_ASSERT(self->magic == IRCOMM_TTY_MAGIC, return;); if (!tty)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |