lkml.org 
[lkml]   [2006]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[Patch] Possible NULL pointer dereference in fs/configfs/dir.c
    From
    Date
    hi,

    this fixes coverity bug #845, if group is NULL,
    we dereference it when setting up dentry.

    Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

    --- linux-2.6.16/fs/configfs/dir.c.orig 2006-03-23 00:02:23.000000000 +0100
    +++ linux-2.6.16/fs/configfs/dir.c 2006-03-23 00:03:49.000000000 +0100
    @@ -500,7 +500,7 @@ static int create_default_group(struct c
    static int populate_groups(struct config_group *group)
    {
    struct config_group *new_group;
    - struct dentry *dentry = group->cg_item.ci_dentry;
    + struct dentry *dentry;
    int ret = 0;
    int i;

    @@ -512,6 +512,8 @@ static int populate_groups(struct config
    * parent to find us, let alone mess with our tree.
    * That said, taking our i_mutex is closer to mkdir
    * emulation, and shouldn't hurt. */
    + dentry = group->cg_item.ci_dentry;
    +
    mutex_lock(&dentry->d_inode->i_mutex);

    for (i = 0; group->default_groups[i]; i++) {

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-23 00:07    [W:0.030 / U:35.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site