lkml.org 
[lkml]   [2006]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCIERR : interfaces for synchronous I/O error detection on driver
    On Wed, Mar 22, 2006 at 05:38:51PM +0900, Hidetoshi Seto wrote:
    > This patch proposes new interfaces, that known by few as iochk_*,
    > for synchronous I/O error detection on PCI drivers.

    Please include the linux-pci mailing list in further discussion of PCI
    specific things.

    > Index: linux-2.6.16_WORK/include/linux/pci.h
    > ===================================================================
    > --- linux-2.6.16_WORK.orig/include/linux/pci.h 2006-03-22
    > 14:27:04.000000000 +0900

    Your patch is linewrapped :(

    > +++ linux-2.6.16_WORK/include/linux/pci.h 2006-03-22
    > 14:41:01.000000000 +0900
    > @@ -696,6 +696,21 @@
    > #endif /* HAVE_ARCH_PCI_RESOURCE_TO_USER */
    >
    >
    > +/* PCIERR_CHECK provides additional interfaces for drivers to detect
    > + * some IO errors, to support drivers can handle errors properly.
    > + * Some archs requiring high-reliability would implement these.
    > + */
    > +#ifdef HAVE_ARCH_PCIERR_CHECK
    > +/* type of iocookie is arch dependent */
    > +extern void pcierr_clear(iocookie *cookie, struct pci_dev *dev);
    > +extern int pcierr_read(iocookie *cookie);
    > +#else
    > +typedef int iocookie;
    > +static inline void pcierr_clear(iocookie *cookie, struct pci_dev *dev) {}
    > +static inline int pcierr_read(iocookie *cookie) { return 0; }
    > +#endif

    We need to see the code that implements this before we can accept a
    header file change.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-22 22:05    [W:0.024 / U:29.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site