Messages in this thread | | | Date | Wed, 22 Mar 2006 10:38:22 -0800 | From | Chris Wright <> | Subject | Re: [RFC PATCH 31/35] Add Xen grant table support |
| |
* Arjan van de Ven (arjan@infradead.org) wrote: > > > + * This file may be distributed separately from the Linux kernel, or > > + * incorporated into other software packages, subject to the following license: > > please again fix the license
*nod*
> > +EXPORT_SYMBOL(gnttab_grant_foreign_access); > > +EXPORT_SYMBOL(gnttab_end_foreign_access_ref); > > +EXPORT_SYMBOL(gnttab_end_foreign_access); > > +EXPORT_SYMBOL(gnttab_query_foreign_access); > > +EXPORT_SYMBOL(gnttab_grant_foreign_transfer); > > +EXPORT_SYMBOL(gnttab_end_foreign_transfer_ref); > > +EXPORT_SYMBOL(gnttab_end_foreign_transfer); > > +EXPORT_SYMBOL(gnttab_alloc_grant_references); > > +EXPORT_SYMBOL(gnttab_free_grant_references); > > +EXPORT_SYMBOL(gnttab_free_grant_reference); > > +EXPORT_SYMBOL(gnttab_claim_grant_reference); > > +EXPORT_SYMBOL(gnttab_release_grant_reference); > > +EXPORT_SYMBOL(gnttab_request_free_callback); > > +EXPORT_SYMBOL(gnttab_grant_foreign_access_ref); > > +EXPORT_SYMBOL(gnttab_grant_foreign_transfer_ref); > > and consider these as _GPL exports
Yes, I meant to note that as one of the known issues. License clarity and _GPL exports.
> > +#ifndef __ia64__ > > +static int map_pte_fn(pte_t *pte, struct page *pte_page, > > + unsigned long addr, void *data) > > +{ > > + unsigned long **frames = (unsigned long **)data; > > + > > + set_pte_at(&init_mm, addr, pte, pfn_pte((*frames)[0], PAGE_KERNEL)); > > + (*frames)++; > > + return 0; > > +} > > looks to me the wrong ifdef for a file in arch/i386... please fix
Yes, the reuse of grant table amongst each Xen supported architecture suggests it's in the wrong location.
thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |