Messages in this thread | | | Date | Tue, 21 Mar 2006 17:46:23 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] fix memory leak in mm/slab.c::alloc_kmemlist() (try #3) |
| |
Christoph Lameter <clameter@sgi.com> wrote: > > On Wed, 22 Mar 2006, Jesper Juhl wrote: > > > Fix memory leak in mm/slab.c::alloc_kmemlist(). > > If one allocation fails we have to roll-back all allocations made up to the > > point of failure. > > Sorry but you cannot roll back. alloc_kmemlist() could have been used for > tuning the cpucache while accesses to the slab continue. "Rolling back" > would partially destroy the slab for some nodes and likely cause the > system to crash. We can only roll back if this is actually an initial > allocation and we are assured that the whole thing is not yet in use.
Well that's a big pickle. How about allocating everything first, saving it locally then, if that all worked out, install it?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |