Messages in this thread | | | Subject | Re: [PATCH] Cpuset: remove unnecessary NULL check | From | (Eric W. Biederman) | Date | Sun, 19 Mar 2006 08:06:10 -0700 |
| |
Paul Jackson <pj@sgi.com> writes:
> Eric wrote: >> Comments that refer to a nebulous hack ... > > Well, in this case, it wasn't so nebulous, to me anyway.
Right. The core problem was there was not enough context to see what the dependency was from the comment.
> > The "Hack" referred to has a big fat comment beginning: > > * > * Hack: > * > * Set the exiting tasks cpuset to the root cpuset (top_cpuset). > * > * Don't leave a task unable to allocate memory, as ... > > and is labeled at the scene of the Hack with: > > tsk->cpuset = &top_cpuset; /* Hack - see comment above */ > > So "Hack" was intended as a proper noun, not a nebulous generic term. > > But, sure, hard to argue with anyone wanting improved comments. > > And while I'm at it, I will change the name of this Hack to something > less generic ... say "the_top_cpuset_hack". > > Patch coming soon.
Thanks.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |