Messages in this thread | | | Date | Sun, 19 Mar 2006 20:04:24 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options |
| |
Phillip Susi <psusi@cfl.rr.com> wrote: > > This patch corrects the incorrect patch previously applied in > commit 4d6660eb3665f22d16aff466eb9d45df6102b254. I had posted > the correction as a reply on lkml, but it seems that the earlier > and incorrect patch got merged into Linus's tree.
I didn't see that update, and I don't miss much.
> --- a/fs/udf/inode.c > +++ b/fs/udf/inode.c > @@ -1341,13 +1341,11 @@ udf_update_inode(struct inode *inode, in > > if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_UID_FORGET)) > fe->uid = cpu_to_le32(-1); > - else if (inode->i_uid != UDF_SB(inode->i_sb)->s_uid) > - fe->uid = cpu_to_le32(inode->i_uid); > + else fe->uid = cpu_to_le32(inode->i_uid); > > if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_GID_FORGET)) > fe->gid = cpu_to_le32(-1); > - else if (inode->i_gid != UDF_SB(inode->i_sb)->s_gid) > - fe->gid = cpu_to_le32(inode->i_gid); > + else fe->gid = cpu_to_le32(inode->i_gid); > > udfperms = ((inode->i_mode & S_IRWXO) ) | > ((inode->i_mode & S_IRWXG) << 2) |
This is an unchangelogged alteration.
Please provide a description of this change. What problem is it fixing? How does it fix it? What are the consequences of not making this change?
Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |