Messages in this thread | | | Date | Fri, 17 Mar 2006 20:59:32 -0500 | From | Latchesar Ionkov <> | Subject | Re: [V9fs-developer] Re: [RESEND][PATCH] v9fs: print v9fs module address |
| |
Yes, it looks like funciton_name+0xoffset is enough for debugging. We can even calculate the module address if we need it.
You can ignore the patch.
Thanks, Lucho
On Fri, Mar 17, 2006 at 01:03:11PM -0800, Andrew Morton said: > Christoph Hellwig <hch@infradead.org> wrote: > > > > On Fri, Mar 17, 2006 at 07:09:14PM +0000, Eric Van Hensbergen wrote: > > > Subject: [PATCH] print v9fs module address > > > From: Latchesar Ionkov <lucho@ionkov.net> > > > Date: 1141313037 -0500 > > > > > > This patch prints v9fs module address when the module is initialized. It is > > > useful to have it in the logs -- if the kernel crashes the address can be > > > used together with the oops print to find out the exact place (presumably in > > > the v9fs code) that cause the oops. > > > > NACK. > > > > This just clutters the log. The information is provided in /proc/modules > > for all modules. > > But it's not printed out in an oops record and it can be hard to read > /proc/modules when the kernel is dead. > > That being said... > > If we really want this info then it should be printed out by the oops code, > where it prints the names of all the loaded modules - add "(0xc0123456)" > after each module name. > > But I can't say I've ever felt a need for this feature - the symbolic info > in the oops trace tells you function_name+0xoffset/0xsize [*] which is > sufficient info for debugging. > > IOW: what's the use case here, Eric? > > > > [*] unless it's x86_64, which randomly prints some of these things in > decimal or sanskrit or something. > > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live webcast > and join the prime developer group breaking into this new coding territory! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 > _______________________________________________ > V9fs-developer mailing list > V9fs-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/v9fs-developer - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |