lkml.org 
[lkml]   [2006]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
    "Eric W. Biederman" wrote:
    >
    > @@ -1573,7 +1573,7 @@ asmlinkage long sys_unshare(unsigned lon
    >
    > if (new_sigh) {
    > sigh = current->sighand;
    > - current->sighand = new_sigh;
    > + rcu_assign_pointer(current->sighand, new_sigh);
    > new_sigh = sigh;
    > }

    Isn't it better to just replace this code with
    'BUG_ON(new_sigh != NULL)' ?

    It is never executed, but totally broken, afaics.
    task_lock() has nothing to do with ->sighand changing.

    Oleg.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-17 18:50    [W:0.022 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site