[lkml]   [2006]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory())
    On Fri, 2006-03-17 at 17:20 +0900, Yasunori Goto wrote:
    > This patch changes name of old add_memory() to arch_add_memory.
    > and use node id to get pgdat for the node at NODE_DATA().
    > Note: Powerpc's old add_memory() is defined as __devinit. However,
    > add_memory() is usually called only after bootup.
    > I suppose it may be redundant. But, I'm not sure about powerpc.
    > So, I keep it. (But, __meminit is better than __devinit at least.)

    My thoughts when originally designing the API were that the architecture
    may be the only bit that actually knows where the memory _is_. So, we
    shouldn't involve the generic code in figuring this out.

    You can see the result of this in the next patch because there is a new
    function introduced to hide the arch-specific node lookup. If that was
    simply done in the already arch-specific add_memory() function, then you
    wouldn't need arch_nid_probe() and its related #ifdefs at all.

    -- Dave

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-03-17 18:15    [W:0.041 / U:2.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site