Messages in this thread | | | Date | Thu, 16 Mar 2006 20:40:55 +0100 (MET) | From | "Michael Kerrisk" <> | Subject | Re: [PATCH] unshare: Cleanup up the sys unshare interfac e before we are committed. |
| |
Eric,
> Since we have not crossed the magic 2.6.16 line can we please > include this patch. My apologies for catching this so late in the > cycle. > > - Error if we are passed any flags we don't expect. > > This preserves forward compatibility so programs that use new flags > that > run on old kernels will fail instead of silently doing the wrong thing. > > - Use separate defines from sys_clone. > > sys_unshare can't implement half of the clone flags under any > circumstances > and those that it does implement have subtlely different semantics than > the clone flags. Using a different set of flags sets the > expectation that things will be different. > > Binary compatibility with current users of the is still maintained > as the unshare flags and the clone flags have the same values.
Thanks for this. I had begun to think I must simply be dense for thinking there was a problem here...
I will update my draft manual page accordingly.
Cheers,
Michael
-- Michael Kerrisk maintainer of Linux man pages Sections 2, 3, 4, 5, and 7
Want to help with man page maintenance? Grab the latest tarball at ftp://ftp.win.tue.nl/pub/linux-local/manpages/, read the HOWTOHELP file and grep the source files for 'FIXME'. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |