Messages in this thread | | | Date | Thu, 16 Mar 2006 08:46:02 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver |
| |
On Wed, 15 Mar 2006, Roland Dreier wrote: > > Andrew> vm_insert_page() mucks around with rmap-named functions > Andrew> which don't actually do rmap and sports > Andrew> apparently-incorrect comments wrt PageReserved(). I don't > Andrew> know how well-cared-for it is... > > Linus just added vm_insert_page() a few months ago. Has it already bit-rotted?
Heh. We relaxed the "needs PG_reserved" requirement, but there's a comment that still says that it needs to in the internal function, which used to be shared between remap_pfn_range and vm_insert_page.
And it uses page_add_file_rmap(), which is misnamed (but that has nothing to do with vm_insert_page).
page_add_file_rmap() doesn't actually do any rmap stuff, it's required for _any_ page that is mapped, and in particular pages that are _not_ rmapped. So vm_insert_page() is doing the right thing, but it looks a bit scary due to bad naming else-where.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |