Messages in this thread | | | Date | Thu, 16 Mar 2006 21:04:22 +1100 | From | Nick Piggin <> | Subject | Re: [PATCH] for_each_possible_cpu [1/19] defines for_each_possible_cpu |
| |
Andrew Morton wrote: > Nick Piggin <nickpiggin@yahoo.com.au> wrote: > >>for_each_cpu has always meant for >> each possible CPU. > > > That was the most long-winded ack I've ever seen ;) >
Is not! :). This is the very reason why I think it is pointless churn. There are plenty of functions (even static, confined to a single file, or ones much more complex than this) which could unquestionably have their names changed for the better.
This change doesn't even add anything except a redundant element so it is even questionable that it makes the name better at all.
But I know you've got your heart set on them now so I won't continue with the impossible task of talking you out of them ;) Just don't expect that people will suddenly start getting hotplug-cpu races right, overnight.
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |