Messages in this thread | | | From | Sergei Organov <> | Subject | Re: [PATCH] Document Linux's memory barriers [try #4] | Date | Wed, 15 Mar 2006 12:04:54 +0300 |
| |
David Howells <dhowells@redhat.com> writes:
> Sergei Organov <osv@javad.com> wrote: > >> "You can prevent an `asm' instruction from being deleted by writing the >> keyword `volatile' after the `asm'. [...] >> The `volatile' keyword indicates that the instruction has important >> side-effects. GCC will not delete a volatile `asm' if it is reachable. >> (The instruction can still be deleted if GCC can prove that >> control-flow will never reach the location of the instruction.) *Note >> that even a volatile `asm' instruction can be moved relative to other >> code, including across jump instructions.*" > > Ummm... If "asm volatile" statements don't form compiler barriers, then how do > you specify a compiler barrier? Or is that what the "memory" bit in: > > #define barrier() __asm__ __volatile__("": : :"memory") > > does?
AFAIU the "memory" tells GCC that this asm has side-effects of changing arbitrary memory addresses. This in turn prevents GCC from keeping memory values in registers through the instruction:
"If your assembler instructions access memory in an unpredictable fashion, add `memory' to the list of clobbered registers. This will cause GCC to not keep memory values cached in registers across the assembler instruction and not optimize stores or loads to that memory. You will also want to add the `volatile' keyword if the memory affected is not listed in the inputs or outputs of the `asm', as the `memory' clobber does not count as a side-effect of the `asm'."
So both volatile and "memory" are required to get true compiler barrier.
-- Sergei. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |