lkml.org 
[lkml]   [2006]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH] Expanding the size of "start" and "end" field in "struct resource"
From
Date
Benjamin LaHaise <bcrl@kvack.org> writes:

> On Wed, Mar 15, 2006 at 02:29:32PM -0700, Eric W. Biederman wrote:
>> If the impact is very slight or unmeasurable this means the option
>> needs to fall under CONFIG_EMBEDDED, where you can change if
>> every last bit of RAM counts but otherwise you won't care.
>
> But we have a data type that is correct for this usage: dma_addr_t.

Well the name is wrong. Because these are in general not DMA addresses,
but it may have the other desired properties. So it may be
useable.

>> Having > 32bit values on a 32bit platform is not the issue.
>>
>> Some drivers appear to puke simply because the value is 64bit. Which
>> means the driver will have problems on any 64bit kernel. That kind
>> of behavior is worth purging.
>
> Forcing it to be a 64 bit value doesn't fix that problem, so that isn't
> a valid excuse for adding bloat.

It doesn't fix it but it finds it. Which is half the battle. Once
the existing references are fixed up it makes it hard to introduce new
breakage like that, because more people see it.

As for bloat this assumes there will be some measurable bloat.
Resources are used in such a limited fashion I will be surprised if
you can measure any bloat.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-15 23:11    [from the cache]
©2003-2011 Jasper Spaans