Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [RFC][PATCH] Expanding the size of "start" and "end" field in "struct resource" | Date | Wed, 15 Mar 2006 14:28:42 -0600 |
| |
On Mar 15, 2006, at 2:13 PM, Eric W. Biederman wrote:
> Kumar Gala <galak@kernel.crashing.org> writes: > >> On Mar 15, 2006, at 1:57 PM, Arjan van de Ven wrote: >> >>> >>>> One of the possible solutions to this problem is that expand the >>>> size >>>> of "start" and "end" to "unsigned long long". But whole of the >>>> PCI and >>>> driver code has been written assuming start and end to be >>>> unsigned long >>>> and compiler starts throwing warnings. >>> >>> >>> please use dma_addr_t then instead of unsigned long long >>> >>> this is the right size on all platforms afaik (could a ppc64 person >>> verify this?> ;) >> >> Actually we really just want "start" and "end" to be u64 on all >> platforms. >> Linus was ok with this change but no one has gone through and >> fixed everything >> that would be required for it. > > Since it is faster to ask :) > > How is it that other pieces of code have problems? > Warnings or something nasty?
Warnings primarily, however I think some places have assumptions about size that have to be looked at.
- kumar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |