lkml.org 
[lkml]   [2006]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH: 003/017](RFC) Memory hotplug for new nodes v.3.(get node id at probe memory)
> > Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> > >
> > > When CONFIG_NUMA && CONFIG_ARCH_MEMORY_PROBE, nid should be defined
> > > before calling add_memory_node(nid, start, size).
> > >
> > > Each arch , which supports CONFIG_NUMA && ARCH_MEMORY_PROBE, should
> > > define arch_nid_probe(paddr);
> > >
> > > Powerpc has nice function. X86_64 has not.....
> >
> > This patch uses an odd mixture of __devinit and <nothing-at-all> in
> > arch/x86_64/mm/init.c. I guess it should be using __meminit
> > throughout.
>
> Oh... I made mistake. I'll fix them.

Hmmm. I'm confusing again about this. :-(

Dave-san, Joel-san.

Why does Powerpc use __devinit for add_memory()?
Usually, add_memory() is never called at boottime.
So, I suppose __meminit nor __devinit is not needed at all around here.

But, does it have a plan that add_memory() is called only boottime on
Powerpc?


--
Yasunori Goto


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-14 12:44    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site