Messages in this thread | | | Date | Tue, 14 Mar 2006 18:09:23 -0600 | From | Mark Maule <> | Subject | Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register |
| |
On Tue, Mar 14, 2006 at 06:55:55PM -0500, Jun'ichi Nomura wrote: > Adrian Bunk wrote: > >>include2/asm/msi.h: In function `ia64_msi_init': > >>include2/asm/msi.h:23: warning: implicit declaration of function > >>`msi_register' > >>In file included from include2/asm/machvec.h:408, > >> from include2/asm/io.h:70, > >> from include2/asm/smp.h:20, > >> from /build/rc6/source/include/linux/smp.h:22, > >>... > > > >To avoid any wrong impression: > > > >This kind of warnings isn't harmless. > > > >gcc tries to guess the prototype of the function, and if gcc guessed > >wrong this can cause nasty and hard to debug runtime errors. > > Sure. > But for this case, gcc emits the above warning for any files > which includes, for example, include/linux/smp.h on ia64. > So while the warning is harmless, it may cause other harmful > warnings being overlooked. >
Yes, this should be cleaned up. I'll take a look.
I thought though that we had all of this compiling cleanly ... guess not.
Mark - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |