lkml.org 
[lkml]   [2006]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] task: Make task list manipulations RCU safe.
From
Date
Oleg Nesterov <oleg@tv-sign.ru> writes:

> "Eric W. Biederman" wrote:
>>
>> Oleg Nesterov <oleg@tv-sign.ru> writes:
>>
>> > Some questions.
>> >
>> > first_tgid:
>> > ...
>> > for (; pos && pid_alive(pos); pos = next_task(pos))
>> >
>> > I think this patch makes this 'pid_alive(pos)' unneeded?
>>
>> Close. The problem is that we could have slept with the
>> count elevated on start before we do rcu_read_lock().
>
> Yes, we could have slept. But (unlike next_tgid) this loop
> starts from pos=init_task or from pos=find_task_by_pid()
> and we are doing find_task_by_pid under rcu_read_lock() ?

Yes. We are sorry. The bits of code blurred in the discussion.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-14 21:19    [W:0.030 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site