lkml.org 
[lkml]   [2006]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.16-rc6] Promise SuperTrak driver
    On Mon, Mar 13, 2006 at 03:42:36PM -0800, Andrew Morton wrote:
    > > +#include <linux/irq.h>
    >
    > Can't include linux/irq.h from generic code (we really ought to fix that).

    In a sense we have -- everybody should include <linux/interrupt.h> and
    not <*/irq.h>. Perhaps we need to poison the includes.

    > > +static inline u16 shasta_alloc_tag(u32 *bitmap)
    > > +{
    > > + u16 i;
    > > + for (i = 0; i < TAG_BITMAP_LENGTH; i++)
    > > + if (!((*bitmap) & (1 << i))) {
    > > + *bitmap |= (1 << i);
    > > + return i;
    > > + }
    > > +
    > > + return TAG_BITMAP_LENGTH;
    > > +}
    >
    > This is too large to be inlined.

    And if I read the driver right, is unnecessary code. It could just use
    the midlayer tag code (ok, not scsi_populate_tag_msg() which is
    SPI-specific, but scsi_activate_tcq(), scsi_deactivate_tcq(),
    scsi_find_tag(), scsi_set_tag_type(), and scsi_get_tag_type() should all
    work, being thin wrappers around the block layer functionality.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-14 21:07    [W:0.023 / U:121.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site