Messages in this thread |  | | | Date | Tue, 14 Mar 2006 02:13:08 -0500 | | From | Jeff Garzik <> | | Subject | Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver |
Andrew Morton wrote: > "Ed Lin" <ed.lin@promise.com> wrote: >>I guess DMA_32BIT_MASK is OK? > > > If that's semantically what the 0xffffffff means then yes.
It means "select lower 32 bits, because the other 32 bits are elsewhere." Since its an arg to cpu_to_le32() I suppose there is an implicit truncation in there, but I add such masking myself to my own code. Makes it more clear to the reader what's going on, IMO.
Its not quite what DMA_32BIT_MASK intends, either, IMO.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |