lkml.org 
[lkml]   [2006]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Patch 9/9] Generic netlink interface for delay accounting
    From
    Date
    On Mon, 2006-03-13 at 19:56 -0500, Shailabh Nagar wrote:
    <snip>

    > Comments addressed (all in response to Jamal)
    >
    > - Eliminated TASKSTATS_CMD_LISTEN and TASKSTATS_CMD_IGNORE

    The enums for these are still in the patch. See below.

    <snip>

    > +/*
    > + * Commands sent from userspace
    > + * Not versioned. New commands should only be inserted at the enum's end
    > + */
    > +
    > +enum {
    > + TASKSTATS_CMD_UNSPEC, /* Reserved */
    > + TASKSTATS_CMD_NONE, /* Not a valid cmd to send
    > + * Marks data sent on task/tgid exit */
    > + TASKSTATS_CMD_LISTEN, /* Start listening */
    > + TASKSTATS_CMD_IGNORE, /* Stop listening */

    >From the description I thought you had eliminated these.

    > + TASKSTATS_CMD_PID, /* Send stats for a pid */
    > + TASKSTATS_CMD_TGID, /* Send stats for a tgid */
    > +};

    Jamal, was your Mon, 13 Mar 2006 21:29:09 -0500 reply:
    > Note, you are still not following the standard scheme of doing things.
    > Example: using command = GET and the message carrying the TGID to note
    > which TGID is of interest. Instead you have command = TGID.
    >
    > cheers,
    > jamal

    meant to suggest that TASKSTATS_CMD_(P|TG)ID should be renamed to
    TASKSTATS_CMD_GET_(P|TG)ID ? Is that sufficient? Or am I
    misunderstanding?

    <snip>

    Cheers,
    -Matt Helsley

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-14 03:44    [W:0.023 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site