![]() | |||||||||||||
Messages in this thread |
On 3/13/06, Jesper Juhl <jesper.juhl@gmail.com> wrote: > On 3/12/06, Andrew Morton <akpm@osdl.org> wrote: > > Jesper Juhl <jesper.juhl@gmail.com> wrote: > > > > > > > > > The Coverity checker found that we may leak memory in > > > mm/slab.c::alloc_kmemlist() > > > This should fix the leak and coverity bug #589 > > > > [snip] > > > > It's more complicated than that. We can also leak new_alien. And if any > > allocation in that for_each_online_node() loop fails I guess we need to > > back out all the allocations we've done thus far, which means another loop. > > ug. > > > Ok, I'll take a second (and much more thorough) look at it tonight. > And I'll be sure to describe whatever changes I make and the reasoning > behind. > > > > Patches against rc6-mm1 would be preferred please, that code's changed > > quite a bit. > > > Sure thing. > Ok, I've been playing around with a few ways to resolve this, but I'm a bit pressed for time and won't have properly tested patches ready tonight. I will however keep at this, so you'll see patches releatively shortly, just give me another day or two and I'll have this fixed in a nice way (nice little task to work at :) ... -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-03-13 21:36 [from the cache] ©2003-2008 | |||||||||||||