lkml.org 
[lkml]   [2006]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/8] saa7110: Fix array overrun
    Fix a (probably harmless) array overrun in the DECODER_DUMP command
    of the saa7110 driver. No big deal as this command is not used
    anywhere anyway. Also reformat the dump so that it displays nicely.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    ---
    drivers/media/video/saa7110.c | 12 +++++-------
    1 file changed, 5 insertions(+), 7 deletions(-)

    --- linux-2.6.16-rc5.orig/drivers/media/video/saa7110.c 2006-03-01 21:09:59.000000000 +0100
    +++ linux-2.6.16-rc5/drivers/media/video/saa7110.c 2006-03-01 21:10:01.000000000 +0100
    @@ -431,15 +431,13 @@
    break;

    case DECODER_DUMP:
    - for (v = 0; v < 0x34; v += 16) {
    + for (v = 0; v < SAA7110_NR_REG; v += 16) {
    int j;
    - dprintk(1, KERN_INFO "%s: %03x\n", I2C_NAME(client),
    + dprintk(1, KERN_DEBUG "%s: %02x:", I2C_NAME(client),
    v);
    - for (j = 0; j < 16; j++) {
    - dprintk(1, KERN_INFO " %02x",
    - decoder->reg[v + j]);
    - }
    - dprintk(1, KERN_INFO "\n");
    + for (j = 0; j < 16 && v + j < SAA7110_NR_REG; j++)
    + dprintk(1, " %02x", decoder->reg[v + j]);
    + dprintk(1, "\n");
    }
    break;

    --
    Jean Delvare
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-13 21:31    [W:0.020 / U:30.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site