lkml.org 
[lkml]   [2006]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: Linux v2.6.16-rc6
    Date
    On Sunday 12 March 2006 02:03, Christoph Hellwig wrote:
    > On Sat, Mar 11, 2006 at 03:58:12PM -0800, Linus Torvalds wrote:
    > > Bjorn Helgaas:
    > > [IA64] don't report !sn2 or !summit hardware as an error
    > > [IA64] SGI SN drivers: don't report !sn2 hardware as an error
    >
    > These should be reverted. They return success from initcalls when they
    > should report failure. In the mmtimer case this is a real bug as it can
    > be modular, in others it's just cosmetic but provides people wrong examples
    > to cut & paste from.

    Do you want all the drivers that just return pci_register_driver(&foo)
    to be changed as well? I haven't heard a compelling argument either way,
    but there are certainly many drivers that return 0 when they successfully
    register a driver that didn't find any devices, e.g.,

    static int __init serial8250_pci_init(void)
    {
    return pci_register_driver(&serial_pci_driver);
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-13 20:58    [W:0.024 / U:1.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site