[lkml]   [2006]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 8 of 20] ipath - sysfs support for core driver
    On Thu, 2006-03-09 at 17:11 -0800, Greg KH wrote:

    > These two files sure do show a lot of different stuff, all in a
    > predefined structure for a single file. Please break them up into the
    > different individual files please.

    The problem is that I want them to be presented together. They look
    like a pile of different stuff, but they're actually Infiniband NodeInfo
    and PortInfo structures. And yes, they are that ugly.

    These files fall into the same categories as the atomic_counters and
    atomic_snapshots files you raised objections to earlier; it actually
    makes sense to look at them as a whole, not their constituent parts.

    In the earlier round of review, people suggested that I use netlink for
    stuff like this, but I quickly decided I'd rather gnaw my leg off than
    use the netlink API.

    I'm thinking at this point that I should just route this information
    through the /dev/ipath_sma char device, and maybe
    add /dev/ipath_counters%d and /dev/ipath_stats to go with it. I think
    that's a pretty crummy approach that sysfs solves more cleanly, but
    there you go.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-03-10 06:12    [W:0.027 / U:75.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site