Messages in this thread | | | Date | Wed, 01 Mar 2006 17:14:21 -0800 | From | Martin Bligh <> | Subject | Re: [PATCH] Fix powerpc bad_page_fault output (Re: 2.6.16-rc5-mm1) |
| |
Paul Mackerras wrote: > Olof Johansson writes: > > >>Seems that the human-readible parts are printed at a differnet printk level >>(well, _at_ a level), so they fell off. Not good. > > > My understanding was that printk lines without a level are considered > to be at KERN_ERR or so. Is that wrong? > > >>Andrew and/or Paulus, see patch below. > > > It really seems strange to be *removing* printk level tags. I'd like > to nack this until I understand why it will improve things. At the > very least it needs a big fat comment so some janitor doesn't come > along and put the tags back in.
He's removing KERN_ALERT ... I guess it could get switched from KERN_ALERT to KERN_ERR, but ...
Either way, KERN_ALERT seems way too low to me. I object to getting half the oops, and not the other half ;-)
M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |