lkml.org 
[lkml]   [2006]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] ocfs2 updates
On Wed, Mar 01, 2006 at 03:37:14PM -0800, Andrew Morton wrote:
> Mark Fasheh <mark.fasheh@oracle.com> wrote:
> >
> > + "Extent %d at e_blkno %"MLFu64" of inode %"MLFu64" goes past ip_clusters of %u\n",
>
> Sometime, please consider killing MLFu64 and friends.
Yeah, it's on my 'todo' list - enough people have asked now that it's clear
folks don't want it. The original idea behind it all was to avoid all the
casts involved. Anyway, I definitely intend to get to it.

> You covered most cases there, but sh64 implements u64 as `unsigned long
> long' (for example).
>
> Generally we solve this problem by just using %ll and casting the args
> appropriately. That does have some runtime cost on 32-bit.
>
> u64 and s64 are the easy case - it gets stickier on things like sector_t
> whose size is controlled by a CONFIG_thing on 32-bit.
Ah, cool. Thanks for pointing those out - it'll help as I try to remove this
stuff.
--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-02 00:54    [W:0.038 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site