lkml.org 
[lkml]   [2006]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.16-rc5-mm1
    Andrew Morton wrote:

    >Maybe you're not running applications which install inotify watches. This
    >is apparently triggerable by doing `touch foo;rm foo;touch foo' in a watched
    >directory.
    >
    >Nick, isn't it simply a matter of..
    >
    >--- devel/fs/dcache.c~inotify-lock-avoidance-with-parent-watch-status-in-dentry-fix 2006-03-01 12:10:48.000000000 -0800
    >+++ devel-akpm/fs/dcache.c 2006-03-01 12:11:33.000000000 -0800
    >@@ -173,6 +173,7 @@ repeat:
    > goto kill_it;
    > if (list_empty(&dentry->d_lru)) {
    > dentry->d_flags |= DCACHE_REFERENCED;
    >+ dentry->d_flags &= DCACHE_INOTIFY_PARENT_WATCHED;
    > list_add(&dentry->d_lru, &dentry_unused);
    > dentry_stat.nr_unused++;
    > }
    >_
    >
    >-
    >

    This doesn;t look quite corect to me. First set DCACHE_REFERENCED in
    the d_flags and then clear every bit in d_flags except
    DCACHE_INOTIFY_PARENT_WATCHED? Should this be
    "~DCACHE_INOTIFY_PARENT_WATCHED"?

    Thanx...

    ps
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-03-01 21:49    [W:4.377 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site