Messages in this thread | | | Date | Wed, 1 Mar 2006 09:59:22 -0800 | From | Mark Fasheh <> | Subject | Re: [PATCH] move eeh_add_device_tree_late() |
| |
On Wed, Mar 01, 2006 at 10:35:55AM -0600, John Rose wrote: > Good catch, Mark. Heh, thanks.
> Commit 827c1a6c1a5dcb2902fecfb648f9af6a532934eb introduced a new > function that calls eeh_add_device_late() implicitly. This patch > reorders the two functions in question to fix the compile error. This > might be preferable to exposing eeh_add_device_late() in eeh.h. Hmm, you still left the EXPORT_SYMBOL(eeh_add_device_late) and you didn't make eeh_add_device_late() static. Shouldn't you do that if you don't want to make it accessible outside of eeh.c? --Mark
-- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |