Messages in this thread | | | Subject | Re: + fork-allow-init-to-become-a-session-leader.patch added to -mm tree | From | (Eric W. Biederman) | Date | Thu, 09 Feb 2006 14:31:32 -0700 |
| |
Christoph Lameter <clameter@engr.sgi.com> writes:
> On Wed, 8 Feb 2006 akpm@osdl.org wrote: > >> + if (unlikely(p->pid == 1)) { >> + p->signal->tty = NULL; >> + p->signal->leader = 1; >> + p->signal->pgrp = 1; >> + p->signal->session = 1; > > Would it not be better to do these special settings for init from > init itself?
So if you mean from within the kernel context that is doable, so long as we only have one process with pid == 1.
Although we may be able fix the kernel limitations in setsid().
For multiple pid == 1 case I don't know of another place in the kernel I can possibly put this. I can't put it later because there is no place later, and I can't put it earlier or else my efforts would just get stomped.
So I did it this way so I don't have to come back and change it to this next week. I'd love to have a better place to put this code.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |